Problem using minver on ubuntu 18.04 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yreynhout
commented
Dec 19, 2018
yreynhout
commented
- Upgraded dependencies which seems to fix the LibGit2Sharp native dll loading issue.
adamralph
reviewed
Dec 19, 2018
| @@ -6,9 +6,9 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="LibGit2Sharp" Version="0.25.3" /> | |||
| <PackageReference Include="LibGit2Sharp" Version="0.26.0-preview-0070" /> | |||
There was a problem hiding this comment.
@bording what's your view on MinVer taking this pre-release dep?
There was a problem hiding this comment.
I think it should be fine. Preview 70 is also the one that removes the curl dependency, so that is another reason to do it.
There was a problem hiding this comment.
It would fix this issue: #171
yreynhout
force-pushed
the
libcurl-issue-on-linux
branch
from
2faab45
to
c7e5f92
Compare
|
Released in beta 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.