Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package on build #473

Closed
wants to merge 1 commit into from
Closed

package on build #473

wants to merge 1 commit into from

Conversation

adamralph
Copy link
Owner

No description provided.

@adamralph adamralph added this to the 2.5.0 milestone Jan 6, 2021
@adamralph adamralph force-pushed the package-on-build branch 3 times, most recently from b1f02a6 to 0feb338 Compare January 6, 2021 13:46
@bording
Copy link
Collaborator

bording commented Jan 6, 2021

I'm not sure I understand the changes here. Making things package on build should not require you to move to a manually created nuspec file.

@adamralph
Copy link
Owner Author

@bording if there's a way to achieve this without a nuspec, I'd love to know about it. 🙂

@adamralph
Copy link
Owner Author

For reference, this is the package layout that needs to be maintained:

│   minver.png
│
├───build
│       MinVer.targets
│
├───buildMultiTargeting
│       MinVer.targets
│
└───minver
        McMaster.Extensions.CommandLineUtils.dll
        MinVer.deps.json
        MinVer.dll
        MinVer.Lib.dll
        MinVer.Lib.pdb
        MinVer.pdb
        MinVer.runtimeconfig.json

@bording
Copy link
Collaborator

bording commented Jan 6, 2021

@bording if there's a way to achieve this without a nuspec, I'd love to know about it. 🙂

I'll take a look at it and see what I can come up with. It's been a while since I've looked at the MinVer project structure, so I need to refresh myself on that.

@bording bording mentioned this pull request Jan 7, 2021
@adamralph
Copy link
Owner Author

withdrawing in favour of #474

@adamralph adamralph closed this Jan 7, 2021
@adamralph adamralph deleted the package-on-build branch January 7, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants