Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle large output when reading #111

Merged
merged 2 commits into from
Feb 4, 2019
Merged

Handle large output when reading #111

merged 2 commits into from
Feb 4, 2019

Conversation

adamralph
Copy link
Owner

@adamralph adamralph commented Feb 4, 2019 •
edited
Loading

As described in #108, when a process returns a large amount of output (several MB), special handling is required to avoid deadlocks in System.Diagnostics.Process.

Closes #108
Closes #109

adamralph and others added 2 commits February 4, 2019 18:10
@adamralph
red: add large output tests
bbed67e
@adamralph @pauldotknopf
green: implement large output
594d195 
Co-authored-by: Paul Knopf <pauldotknopf@gmail.com>
@adamralph adamralph added this to the 5.0.0 milestone Feb 4, 2019
@adamralph adamralph changed the title implement large output Handle large output when reading Feb 4, 2019
@adamralph adamralph added the enhancement New feature or request label Feb 4, 2019
@adamralph adamralph merged commit f7c116d into master Feb 4, 2019
@adamralph adamralph deleted the large-stdout branch February 4, 2019 17:21
@adamralph adamralph mentioned this pull request Feb 4, 2019
Closed
@adamralph
Copy link
Owner Author

Released in alpha 2.

/cc @pauldotknopf @thefringeninja

@adamralph adamralph mentioned this pull request Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adamralph