Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Echo suppression #36

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Echo suppression #36

merged 1 commit into from
Aug 11, 2018

Conversation

adamralph
Copy link
Owner

@adamralph adamralph commented Aug 11, 2018 •
edited
Loading

New overloads of Run*() and Read*() with a bool noEcho parameter.

Kudos to @pauldotknopf for raising the requirement in #29. 馃

@adamralph adamralph added the enhancement New feature or request label Aug 11, 2018
@adamralph adamralph added this to the 2.3.0 milestone Aug 11, 2018
@adamralph adamralph merged commit 667960e into master Aug 11, 2018
@adamralph adamralph deleted the no-echo branch August 11, 2018 17:54
@adamralph adamralph mentioned this pull request Aug 11, 2018
Closed
@adamralph
Copy link
Owner Author

@pauldotknopf FYI I've released 4.0.0 beta 1 which uses optional arguments instead of all the overrides. Given that you are using the noEcho parameter, if you'd like to give it the beta a try, I'd really appreciate any feedback you may have.

@adamralph adamralph mentioned this pull request Nov 21, 2018
Closed
14 tasks
@adamralph adamralph mentioned this pull request Jun 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adamralph