Skip to content
This repository has been archived by the owner on Jun 12, 2021. It is now read-only.

Background steps showing as dummy inconclusive tests in ReSharper #410

Closed
adamralph opened this issue Dec 10, 2017 · 5 comments
Closed

Background steps showing as dummy inconclusive tests in ReSharper #410

adamralph opened this issue Dec 10, 2017 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@adamralph
Copy link
Owner

Outcome of #409.

image

This is because [Background] is redundantly inheriting from [Fact]. It's arguable that ReSharper should not be showing the test at all, as other runners do, but in any case, the inheritance is redundant and can be removed, which will fix this problem immediately, regardless of any changes to ReSharper.

Thanks to @eyalsk for discovering this.

@adamralph adamralph added the bug Something isn't working label Dec 10, 2017
@adamralph adamralph added this to the 2.3.1 milestone Dec 10, 2017
@adamralph adamralph self-assigned this Dec 10, 2017
@adamralph
Copy link
Owner Author

@eyalsk I've released https://www.nuget.org/packages/Xbehave/2.3.1-alpha0001-build731 which contains a fix for this problem. Would you be able to give it a try to verify?

@iam3yal
Copy link

iam3yal commented Dec 13, 2017

@adamralph Sure! 😄

@iam3yal
Copy link

iam3yal commented Dec 13, 2017

@adamralph It seems to work great, have you implemented the ability to change where the (Background) text appears?

@adamralph
Copy link
Owner Author

@eyalsk great, thanks for verifying.

have you implemented the ability to change where the (Background) text appears?

Not yet, watch #411 for updates on that.

@adamralph
Copy link
Owner Author

Released in 2.3.1 - https://twitter.com/adamralph/status/998611366817746944

Thanks @eyalsk. Look out for your name in the release notes! https://github.com/xbehave/xbehave.net/releases/tag/2.3.1 🏆

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants