Bug 994146: Panel should be reset when closed. #19
Conversation
|
Apologies, I didn't get a chance to poke at this today. I felt like I had to give priority to the various architecture untangling, since that's really the long pole in the tent. :-( |
| document: fakeDocument | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Clever; I like this testing methodology!
|
Out of curiosity, why does it make sense for the panel to have a router at all? Is there really likely to be more than one full-page view for the panel? Or is this to it easier on the shared code stuff? I suspect there's nothing worth changing here; this question is more for my own understanding. |
|
Looks good, r=dmose with any appropriate stuff addressed. |
For two reasons; the first one is to ensure consistency across the different project apps (webapp, panel & conversation window). The second is to ensure easing further evolutions for the panel, eg. adding support for the contact list and so on. |
Related bug: https://bugzilla.mozilla.org/show_bug.cgi?id=994146