Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 972020 - Loop basic UI #23

Merged
merged 1 commit into from May 14, 2014
Merged

Bug 972020 - Loop basic UI #23

merged 1 commit into from May 14, 2014

Conversation

Standard8
Copy link
Collaborator

No description provided.

<!-- libs -->
<script>
// Components won't load in unprivileged space, faking this one.
var FirefoxCom = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop is no longer using FirefoxCom, so we should remove this now (in a follow-up).

@Standard8
Copy link
Collaborator Author

The code is fine. Where I've had comments, the code has already been superseded so there's not much to do apart from that one removal.

There's a couple of images and css files we've added, that now make me think they should be in the browser/themes directory, though I'm not sure of the precise rules there - we'll need to ask some folks - so I'll file a follow-up bug for those.

r=Standard8

@Standard8 Standard8 merged commit 804d9dc into master May 14, 2014
@n1k0 n1k0 deleted the bug-972020 branch May 15, 2014 08:31
ekr added a commit that referenced this pull request Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants