properly handles commands with arguments.

adamsanderson · May 2, 2009 · ee15a7e · ee15a7e
1 parent bf2b15d
commit ee15a7e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/rubygems/commands/open_command.rb b/lib/rubygems/commands/open_command.rb
@@ -1,3 +1,5 @@
+require 'shellwords'
+
 require 'rubygems/command'
 require 'rubygems/dependency'
 require 'rubygems/version_option'
@@ -60,7 +62,9 @@ def open_gem(path)
     if !editor
       say "Either set $EDITOR, or use -c <command_name>"
     else
-      success = system(editor, path)
+      command_parts = Shellwords.shellwords(editor)
+      command_parts << path
+      success = system(*command_parts)
       if !success 
         raise Gem::CommandLineError, "Could not run '#{editor} #{path}', exit code: #{$?.exitstatus}"
       end

diff --git a/test/open_command_test.rb b/test/open_command_test.rb
@@ -38,5 +38,4 @@ def test_opening_with_no_gem_name
       command.invoke()
     end
   end
-
 end