Fixed buggy AMD implementation #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@tHBp Thanks so much for your contribution. I would very much like to improve the library’s reusability by implementing UMD. However, this PR seems to have made some additional changes to the codebase, including changing the indentation from 2 spaces to 4, and adding |
Implemented Universal Module Definition to support buggy existing AMD implementation.
|
I have implemented the suggested changes and updated the PR. If it is reasonable to you, can you also publish the same to npm once changes are merged? That'd be great. Thanks. |
|
Should be all set https://www.npmjs.com/package/chrome-tabs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Universal Module Definition to support buggy existing AMD implementation.