Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add waiting notice and support missing web-vitals script #1

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Add waiting notice and support missing web-vitals script #1

merged 4 commits into from
Jul 20, 2023

Conversation

crstauf
Copy link

@crstauf crstauf commented Jul 19, 2023

No description provided.

@crstauf crstauf mentioned this pull request Jul 19, 2023
Open
@crstauf
Copy link
Author

crstauf commented Jul 19, 2023

Also prefixed script handle with qm- and changed version to the script's version, rather than QM's version. This will make it clear what version is being used and if there's an update.

adamsilverstein
adamsilverstein approved these changes Jul 20, 2023
View reviewed changes
Copy link
Owner

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@adamsilverstein adamsilverstein merged commit 0038a89 into adamsilverstein:add/web-vitals Jul 20, 2023
@crstauf crstauf deleted the patch-1 branch July 20, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crstauf @adamsilverstein