This repository has been archived by the owner on Feb 26, 2018. It is now read-only.
Support for ->required() on the label within a form group #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By intercepting the `required($conditional)` function here we will add automatically the `control-label-required` CSS class to the `<label>` HTML element.
This way you are able to use CSS to style the `<label>` HTML element however you want, you can even use pseudo-elements to add an asterisk:
```css
label.control-label-required:after {
content: " *";
}
```
Obviously we wont interfere with Form Builder and we'll call the `required()` function defined within `adamwathan/form` no matter what. The CSS class will just be added conditionally.
clemblanco
changed the title
->required() on the label within a form group
Closed
|
Anyone pretty please? @adamwathan? |
|
Sure why not 🤷♂️ |
|
|
|
Any chance this goes into a release? Would like to avoid having to use |
|
Done |
|
Amazing! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By intercepting the
required($conditional)function here we will add automatically thecontrol-label-requiredCSS class to the<label>HTML element.This way you are able to use CSS to style the
<label>HTML element however you want, you can even use pseudo-elements to add an asterisk:Obviously we wont interfere with Form Builder and we'll call the
required()function defined withinadamwathan/formno matter what. The CSS class will just be added conditionally.