Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrap stuck after bezeling many pages quickly #956

Closed
heatherwong opened this issue Oct 21, 2014 · 18 comments
Closed

scrap stuck after bezeling many pages quickly #956

heatherwong opened this issue Oct 21, 2014 · 18 comments

Comments

@heatherwong
Copy link

  1. load up the 100 pages of small data set
  2. select a page from top of list
  3. add new page
  4. insert scrap
  5. hold scrap and bezel quickly through ~20 pages
  6. can no longer bezel to next page after ~15 pages or so. but can still hold/resize/move scrap. cannot pinch to list view, cannot go to next page

tested in RC1
iOS8 ipad mini

@heatherwong
Copy link
Author

after force quitting app and restarting. the scrap is partially blank - see attached.
2014-10-21_0030

@adamwulf
Copy link
Owner

i just reproduced that white corner problem. it looks like it's independent
of this AT though, i'm seeing this problem on a number of scraps now. we
should open a new issue for it

On Tue, Oct 21, 2014 at 2:31 AM, heatherwong notifications@github.com
wrote:

after force quitting app and restarting. the scrap is partially blank -
see attached.
[image: 2014-10-21_0030]
https://cloud.githubusercontent.com/assets/1190936/4714586/3a02491a-58f4-11e4-908b-13a471b67897.png


Reply to this email directly or view it on GitHub
#956 (comment).

@heatherwong
Copy link
Author

filed #959

@heatherwong
Copy link
Author

you beat me to it :)

@adamwulf
Copy link
Owner

related to #939. i was able to repro the crash with the UndoManager, but haven't been able to get it stuck or frozen. though, the fix in #939 could very well fix a race condition (it used to save + unload a page at the same time, now it will wait for the save then unload), so i suspect that #939 did fix this one as well.

I'll send you a build, lmk if you can still repro. i'll keep trying as well

@heatherwong
Copy link
Author

just repro'd this in RC2 ios7 ipad 2 + ios 8 ipad mini

@adamwulf
Copy link
Owner

it froze? or crashed? i just saw 963 come through, which looks like a dup
of 896

On Wed, Oct 22, 2014 at 1:32 AM, heatherwong notifications@github.com
wrote:

just repro'd this in RC2 ios7 ipad 2


Reply to this email directly or view it on GitHub
#956 (comment).

@heatherwong
Copy link
Author

froze

@heatherwong
Copy link
Author

I cannot pinch to list view.

I can select different buttons on tool bar, zoom in/out scrap that i was holding during bezel, insert new image

@heatherwong
Copy link
Author

haven't been able to get it to freeze state in RC6, just crashing consistently #982 #983 #984

iPad 2 iOS 7.1.1
iPad Mini iOS 8.0

@adamwulf
Copy link
Owner

roughly how many pages can you bezel through before a crash?

On Thu, Oct 23, 2014 at 4:49 AM, heatherwong notifications@github.com
wrote:

haven't been able to get it to freeze state in RC6, just crashing
consistently #982 #982 #983
#983 #984
#984

iPad 2 iOS 7.1.1
iPad Mini iOS 8.0


Reply to this email directly or view it on GitHub
#956 (comment).

@heatherwong
Copy link
Author

~15-20 pages for first crash. after first crash, it's more sensitive and will crash with 2-3 pages

@adamwulf
Copy link
Owner

Cool, this'll be first on my list tomorrow then

Adam

On Oct 23, 2014, at 4:53 AM, heatherwong notifications@github.com wrote:

~15-20 pages for first crash. after first crash, it's more sensitive and will crash with 2-3 pages


Reply to this email directly or view it on GitHub.

@adamwulf
Copy link
Owner

Is it stable enough that I should send it out to all the other testers?

On Oct 23, 2014, at 4:53 AM, heatherwong notifications@github.com wrote:

~15-20 pages for first crash. after first crash, it's more sensitive and will crash with 2-3 pages


Reply to this email directly or view it on GitHub.

@heatherwong
Copy link
Author

yeah it’s stable enough.
On Oct 23, 2014, at 2:59 AM, Adam Wulf notifications@github.com wrote:

Is it stable enough that I should send it out to all the other testers?

On Oct 23, 2014, at 4:53 AM, heatherwong notifications@github.com wrote:

~15-20 pages for first crash. after first crash, it's more sensitive and will crash with 2-3 pages


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

@adamwulf
Copy link
Owner

on iPad 3, iOS8, i made it through 70 pages before a crash. next run i made it through all 100 pages twice w/o crash, then crashed on page ~15 on the 3rd time through. in RC8

@heatherwong
Copy link
Author

I was able to get through all 100 pages with no crash in RC9!
iPad 2 iOS 7.1.1
iPad Mini iOS 8.0

@adamwulf
Copy link
Owner

awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants