Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use InvariantCulture to convert double representation of ModifiedDate to string #14

Merged
merged 1 commit into from
Oct 16, 2015

Conversation

DriesPeeters
Copy link
Contributor

Hi,

I live in Belgium and I had a bug when I use the getPushes method.
I always got the following error: {"Assert.Fail failed. 400 Bad Request - Usually this results from missing a required parameter."}

After some debugging I found that the Pushbullet API does not work with comma characters in the modified_after field. Since this field can be a double value, and in Belgium the default conversion of a double to a string contains a comma, I changed the double to string conversion code in the getPushes method.

Reproduction of the error:

  1. Change your laptop's region setting to 'Dutch (Belgium)'
  2. Use a non integer DateTime value (as I added in the unit test)
  3. Execute the GetPushesAllSince unit test
  4. You will get the error above

Done to fix the issue:
Changed the Culture of the conversion to InvariantCulture.

Kind regards,
Dries

adamyeager added a commit that referenced this pull request Oct 16, 2015
Use InvariantCulture to convert double representation of ModifiedDate to string
@adamyeager adamyeager merged commit ef500d4 into adamyeager:Integration Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants