Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mp3 support #35

Closed
adangert opened this issue Feb 3, 2017 · 3 comments
Closed

mp3 support #35

adangert opened this issue Feb 3, 2017 · 3 comments
Labels
enhancement help wanted

Comments

@adangert
Copy link
Owner

adangert commented Feb 3, 2017

right now, wavs are supported, mp3 support needs to be added and tested, This might be difficult with the real-time resampling in piaudio.py, perhaps quickly convert the mp3 to a temp wav first before the game starts then delete it after the round is over?
@CelestialQwert
Copy link
Collaborator

I poked around a little bit and sticking with wav seems to be the best bet without a ton of coding. I'd whip up a script (pydub looks good) that quickly converts typical formats into wavs and just save those. Maybe have that script run on the included song to save some download time?

@adangert
Copy link
Owner Author

Yeah that probably would be the best solution for now.

@adangert
Copy link
Owner Author

now supports mp3, flac, ogg and others http://www.ffmpeg.org/general.html#File-Formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adangert @CelestialQwert