Remove obsolete examples and rename one to fit into the schema (#1328)

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
adap · Jul 25, 2022 · b2c3bfa · b2c3bfa
1 parent 831b473
commit b2c3bfa
Show file tree

Hide file tree

Showing 19 changed files with 6 additions and 635 deletions.
diff --git a/.github/workflows/examples.yml b/.github/workflows/examples.yml
@@ -179,36 +179,3 @@ jobs:
             then echo "Client process 2 started correctly";
             else echo "Client process 2 crashed" && exit 1;
           fi
-
-  test_simulation:
-    runs-on: ubuntu-20.04
-    steps:
-      - uses: actions/checkout@v2
-      - name: Set up Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.7.12
-      - name: Install
-        run: |
-          python -m pip install -U pip==22.0.4
-          python -m pip install -U setuptools==60.9.3
-          python -m pip install poetry==1.1.13
-          poetry config virtualenvs.create false
-      - name: Install dependencies
-        run: |
-          cd examples/simulation
-          python -m poetry install
-      - name: Import flwr
-        run: |
-          python3 -c "import flwr"
-      - name: Test
-        run: |
-          cd examples/simulation
-
-          python3 simulation.py &
-          sleep 10
-
-          if [[ $(ps aux | grep "python simulation.py" | awk '{ print $2 }') ]];
-            then echo "Simulation process started correctly";
-            else echo "Simulation process crashed" && exit 1;
-          fi
diff --git a/doc/source/changelog.md b/doc/source/changelog.md
@@ -115,7 +115,11 @@ We thank all contributors who made Flower 1.0 possible (in reverse [GitHub Contr
   - `quickstart_pytorch`
   - `quickstart_simulation`
   - `quickstart_tensorflow`
-  - `advanced_tensorflow`.
+  - `advanced_tensorflow`
+
+- **Remove the obsolete simulation example** ([#1328](https://github.com/adap/flower/pull/1328))
+
+  Removes the obsolete `simulation` example and renames `quickstart_simulation` to `simulation_tensorflow` so it fits withs the naming of `simulation_pytorch`
 
 - **Updated documentation** ([#1223](https://github.com/adap/flower/pull/1223), [#1209](https://github.com/adap/flower/pull/1209), [#1251](https://github.com/adap/flower/pull/1251), [#1257](https://github.com/adap/flower/pull/1257), [#1267](https://github.com/adap/flower/pull/1267), [#1268](https://github.com/adap/flower/pull/1268), [#1300](https://github.com/adap/flower/pull/1300), [#1304](https://github.com/adap/flower/pull/1304), [#1305](https://github.com/adap/flower/pull/1305), [#1307](https://github.com/adap/flower/pull/1307))
 

diff --git a/examples/simulation/Dockerfile b/examples/simulation/Dockerfile
diff --git a/examples/simulation/README.md b/examples/simulation/README.md
diff --git a/examples/simulation/dataset.py b/examples/simulation/dataset.py
diff --git a/examples/simulation/pyproject.toml b/examples/simulation/pyproject.toml
diff --git a/examples/simulation/run.sh b/examples/simulation/run.sh
diff --git a/examples/simulation/simulation.py b/examples/simulation/simulation.py
diff --git a/examples/simulation_pytorch_legacy/Dockerfile b/examples/simulation_pytorch_legacy/Dockerfile