Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Ray and updating simulation_pytorch example #1036

Merged
merged 5 commits into from Feb 4, 2022

Conversation

jafermarq
Copy link
Contributor

This PR updates the Ray version, as dicussed in Issue #1016. I have also used this opportunity to slightly update the simulation_pytorch example by:

  • Updating the main to explain what the example is about.
  • Exposed a couple of hyperparamters via argparse. I think it is quite relevant to do so for num_client_cpus which controls the number of threads assigned to each client.
  • Moved boilerplate code to a new script, utils.py. This is something suggested by @mariaboerner1987 .

@jafermarq
Copy link
Contributor Author

One point I wanted to ask: do we need a pyproject.toml for this example? One was added a while back.

danieljanes
danieljanes previously approved these changes Feb 3, 2022
@danieljanes
Copy link
Member

Thanks for the update @jafermarq , looks good! I've approved the PR, but one question: is the switch from 5 to 20 local epochs intentional?

Re pyproject.toml, yes it's needed. We're following the general idea that each example is a self-contained project, pyproject.toml is mainly there to list dependencies. One thing we might do in the future is to have a requirements.txt (in addition to pyproject.toml) to make the examples more approachable for users who do not want to use Poetry.

@jafermarq
Copy link
Contributor Author

jafermarq commented Feb 3, 2022

@danieljanes , I see now what you mean about the epochs. I've reverted down to 5 local epochs (making it a more realistic settings). Good catch.

@danieljanes danieljanes enabled auto-merge (squash) February 4, 2022 13:31
@danieljanes danieljanes merged commit dbbb91c into main Feb 4, 2022
@danieljanes danieljanes deleted the upgrading_ray_and_example branch February 4, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants