Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform centralized and federated evaluation #1091

Merged
merged 7 commits into from Mar 1, 2022

Conversation

sancarlim
Copy link
Contributor

What does this implement/fix? Explain your changes.

When giving a centralized evaluation function, decentralized evaluation is not performed.
This gives the option to perform both centralized and federated evaluation by passing {"fed_eval": 1} to on_fit_config_fn() in the strategy.

Give the option to perform both centralized and federated evaluation by passing {"fed_eval": 1} to on_fit_config_fn() in the strategy.
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sandracl72 ! I've added two comments below.

Once we converge to a solution we should make the same changes in qfedavg.py and fedavg_android.py to keep different strategies consistent.

src/py/flwr/server/strategy/fedavg.py Show resolved Hide resolved
src/py/flwr/server/strategy/fedavg.py Outdated Show resolved Hide resolved
@danieljanes danieljanes self-assigned this Feb 24, 2022
src/py/flwr/server/strategy/fedavg.py Outdated Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) March 1, 2022 15:56
@danieljanes danieljanes merged commit c3ccc84 into adap:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants