add ios sdk and example with CoreML #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @danielnugraha, very cool! Could you move the code into |
danieljanes
requested changes
Jul 16, 2022
There was a problem hiding this comment.
Finished a first high-level review of this PR and left a few comments (mainly updating the README and potentially shortening server.py). I look forward to merging it soon to make it available to the community, we can then continue to iterate on the iOS example/SDK in follow-up PRs.
The biggest update we'll have to do in a follow-up PR is to make it compatible with Flower 1.0 (which changes transport.proto to handle optional client methods).
Again, thanks for the PR, great work!
danieljanes
requested changes
Aug 5, 2022
There was a problem hiding this comment.
Hi @danielnugraha, just one comment about the strategy left, apart from that it looks good!
danieljanes
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Added a Flower iOS SDK (as a Swift package) for Flower client and a working example with CoreML.
Transport.proto is compiled using Swift protobuf compiler plug-in provided by grpc-swift and produces 2 files, 1 for the messages and 1 for the services.
The Flower client in iOS is translated from python and uses the same structure as python Flower client.
The only exception is the Parameter file. Right now to be able to use the python server out of the box and its built in strategies the model parameters from the client will be converted into numpy array using Python-iOS and sent as bytes to the server as a message in FitRes or getParameters.
Model parameters from the server will also be converted to swift array (in this case MLMultiArray).
The example uses a Digit Recognition CoreML Model and MNIST Dataset as csv (there are no official dataset for swift so I use the dataset provided in https://github.com/JacopoMangiavacchi/MNIST-CoreML-Training).
How to test: