Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete examples and rename one to fit into the schema #1328

Merged
merged 4 commits into from
Jul 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,36 +179,3 @@ jobs:
then echo "Client process 2 started correctly";
else echo "Client process 2 crashed" && exit 1;
fi

test_simulation:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.7.12
- name: Install
run: |
python -m pip install -U pip==22.0.4
python -m pip install -U setuptools==60.9.3
python -m pip install poetry==1.1.13
poetry config virtualenvs.create false
- name: Install dependencies
run: |
cd examples/simulation
python -m poetry install
- name: Import flwr
run: |
python3 -c "import flwr"
- name: Test
run: |
cd examples/simulation

python3 simulation.py &
sleep 10

if [[ $(ps aux | grep "python simulation.py" | awk '{ print $2 }') ]];
then echo "Simulation process started correctly";
else echo "Simulation process crashed" && exit 1;
fi
6 changes: 5 additions & 1 deletion doc/source/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ We thank all contributors who made Flower 1.0 possible (in reverse [GitHub Contr
- `quickstart_pytorch`
- `quickstart_simulation`
- `quickstart_tensorflow`
- `advanced_tensorflow`.
- `advanced_tensorflow`

- **Remove the obsolete simulation example** ([#1328](https://github.com/adap/flower/pull/1328))

Removes the obsolete `simulation` example and renames `quickstart_simulation` to `simulation_tensorflow` so it fits withs the naming of `simulation_pytorch`

- **Updated documentation** ([#1223](https://github.com/adap/flower/pull/1223), [#1209](https://github.com/adap/flower/pull/1209), [#1251](https://github.com/adap/flower/pull/1251), [#1257](https://github.com/adap/flower/pull/1257), [#1267](https://github.com/adap/flower/pull/1267), [#1268](https://github.com/adap/flower/pull/1268), [#1300](https://github.com/adap/flower/pull/1300), [#1304](https://github.com/adap/flower/pull/1304), [#1305](https://github.com/adap/flower/pull/1305), [#1307](https://github.com/adap/flower/pull/1307))

Expand Down
20 changes: 0 additions & 20 deletions examples/simulation/Dockerfile

This file was deleted.

68 changes: 0 additions & 68 deletions examples/simulation/README.md

This file was deleted.

59 changes: 0 additions & 59 deletions examples/simulation/dataset.py

This file was deleted.

17 changes: 0 additions & 17 deletions examples/simulation/pyproject.toml

This file was deleted.

5 changes: 0 additions & 5 deletions examples/simulation/run.sh

This file was deleted.

95 changes: 0 additions & 95 deletions examples/simulation/simulation.py

This file was deleted.

16 changes: 0 additions & 16 deletions examples/simulation_pytorch_legacy/Dockerfile

This file was deleted.

Loading