Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyTorch E2E test #2072

Merged
merged 3 commits into from Jul 10, 2023
Merged

Update PyTorch E2E test #2072

merged 3 commits into from Jul 10, 2023

Conversation

charlesbvll
Copy link
Member

@charlesbvll charlesbvll commented Jul 10, 2023

Issue

Description

PyTorch E2E test's client file ran the training when importing.

Related issues/PRs

#1974

Proposal

Explanation

Only run training when file is called directly.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@charlesbvll charlesbvll mentioned this pull request Jul 10, 2023
3 tasks
@charlesbvll charlesbvll marked this pull request as ready for review July 10, 2023 08:33
@tanertopal tanertopal enabled auto-merge (squash) July 10, 2023 08:41
@tanertopal tanertopal merged commit da68aa9 into main Jul 10, 2023
10 checks passed
@tanertopal tanertopal deleted the update-pytorch-e2e branch July 10, 2023 08:49
tanertopal added a commit that referenced this pull request Jul 11, 2023
* main:
  Add new baselines test github workflow (#2009)
  Add simulation to E2E tests (#2074)
  Add E2E test for Pandas (#2070)
  Add E2E test for scikit-learn (#2073)
  Add format and test scripts (#1987)
  Add missing ruff dependency to baselines (#2075)
  Add E2E test for MXNet (#2069)
  Add E2E test for Jax (#2067)
  Update bare E2E test client (#2068)
  Update PyTorch E2E test (#2072)
  Update Tensorflow E2E test (#2071)
  Fix flake8 error E266 in baseline template (#2065)
  Fix baseline creation on linux-based systems (#2063)
  Updates to Baseline Template Readmes (#2059)
  Refresh FedProx MNIST baseline (#1918)
  Extend test checking tools config (#1986)
  Improved documentation (#2006)
  updated material for 30min FL tutorial (#2005)
  Update codeowners list (#2004)
  Create and delete nodes via Fleet API (#1901)
alessiomora pushed a commit to alessiomora/flower that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants