Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Flower client #2349

Merged
merged 4 commits into from Sep 12, 2023
Merged

Refactor Flower client #2349

merged 4 commits into from Sep 12, 2023

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Sep 12, 2023 •
edited

Refactored Flower client:

  • created a typing.py in client where types used throughout flower (ClientLike and ClientFn) are defined. It makes easier to access them like this instead that from client app where many things are imported.
  • Moved all the numpy wrapping logic to numpy_client_wrapper.py, again so we can access important functions such as to_client() w/o having to worry about circular imports due to it being previously defined in client app

@jafermarq jafermarq mentioned this pull request Sep 12, 2023
Merged
6 tasks
@jafermarq jafermarq marked this pull request as ready for review September 12, 2023 11:14
@danieljanes danieljanes enabled auto-merge (squash) September 12, 2023 11:56
@danieljanes danieljanes merged commit 750dd3c into main Sep 12, 2023
26 checks passed
@danieljanes danieljanes deleted the client_refactor branch September 12, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jafermarq @danieljanes