Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update baseline creation instruction #2435

Merged
merged 11 commits into from Oct 16, 2023
Merged

Update baseline creation instruction #2435

merged 11 commits into from Oct 16, 2023

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Sep 30, 2023 •
edited

Small change, to indicate the baseline name should be a single lowercase word.

Edited baselines docs:

  • existing "tutorial" pages are moved to "how-to" pages.
  • minor changes here and there
  • do we need the Tutorials/References section in the index.rst?

@jafermarq jafermarq marked this pull request as ready for review October 14, 2023 11:04
danieljanes
danieljanes requested changes Oct 14, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one comment

baselines/doc/source/index.rst Outdated Show resolved Hide resolved
@danieljanes danieljanes merged commit 76081b0 into main Oct 16, 2023
26 checks passed
@danieljanes danieljanes deleted the jafermarq-patch-1 branch October 16, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jafermarq @danieljanes