Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart-fastai requirements #2467

Merged
merged 11 commits into from Feb 16, 2024
Merged

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented Oct 5, 2023

Issue

Description

Quickstart-fastai's pyproject.toml and requirements.txt is not synced.

Related issues/PRs

Proposal

Explanation

Sync pyproject.toml and requirements.txt

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@jafermarq
Copy link
Contributor

This example seems to run fine on x86 machine but triggers segmentation fault when running on M1/M2 macs (arm64).

@danielnugraha
Copy link
Contributor Author

This example seems to run fine on x86 machine but triggers segmentation fault when running on M1/M2 macs (arm64).

@jafermarq I run it in my Mac and it works. Run it in python v3.8, v3.9, v3.10.

@tanertopal
Copy link
Member

@jafermarq @danielnugraha is this still relevant? Let's get it merged or close it otherwise.

@jafermarq jafermarq merged commit d76a6f2 into main Feb 16, 2024
27 checks passed
@jafermarq jafermarq deleted the update-quickstart-fastai-reqs branch February 16, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants