Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename draft release workflow and create release #2658

Merged
merged 12 commits into from Dec 25, 2023
Merged

Conversation

charlesbvll
Copy link
Member

Issue

Description

The current release workflow doesn't actually release the package to PyPi, it just creates a draft.

Related issues/PRs

N/A

Proposal

Explanation

This new script (named framework-release.yml, while the old one is renamed framework-draft-release.yml) downloads the artifacts from the artifact store and publishes the package to PyPi once the draft is set to published.

Checklist

  • Implement proposed change
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added two small suggestions.

.github/workflows/framework-release.yml Outdated Show resolved Hide resolved
.github/workflows/framework-release.yml Outdated Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) December 22, 2023 13:07
@danieljanes danieljanes merged commit 213cc3e into main Dec 25, 2023
27 checks passed
@danieljanes danieljanes deleted the add-release-workflow branch December 25, 2023 11:44
mohammadnaseri added a commit that referenced this pull request Jan 9, 2024
Fix the static method error

---------

Co-authored-by: Daniel J. Beutel <daniel@flower.dev>
Co-authored-by: Robert Steiner <robert@flower.dev>

Update types-requests requirement from ==2.31.0.2 to ==2.31.0.10 (#2739)

Updates the requirements on [types-requests](https://github.com/python/typeshed) to permit the latest version.
- [Commits](https://github.com/python/typeshed/commits)

---
updated-dependencies:
- dependency-name: types-requests  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taner Topal <taner@flower.dev>

Make the optional arg "--callable" in `flower-client` a required positional arg. (#2673)

Co-authored-by: Javier <jafermarq@users.noreply.github.com>

Update jupyterlab requirement from ==4.0.8 to ==4.0.9 (#2740)

Updates the requirements on [jupyterlab](https://github.com/jupyterlab/jupyterlab) to permit the latest version.
- [Release notes](https://github.com/jupyterlab/jupyterlab/releases)
- [Changelog](https://github.com/jupyterlab/jupyterlab/blob/@jupyterlab/lsp@4.0.9/CHANGELOG.md)
- [Commits](https://github.com/jupyterlab/jupyterlab/compare/@jupyterlab/lsp@4.0.8...@jupyterlab/lsp@4.0.9)

---
updated-dependencies:
- dependency-name: jupyterlab
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taner Topal <taner@flower.dev>

HeteroFL baseline (#2439)

Co-authored-by: jafermarq <javier@flower.dev>

Retire `MXNet` examples (#2724)

Co-authored-by: Taner Topal <taner@flower.dev>

Rename draft release workflow and create release (#2658)

Update Android manifest to include internet permission (#2672)

Bump lewagon/wait-on-check-action from 1.3.1 to 1.3.3 (#2756)

Bumps [lewagon/wait-on-check-action](https://github.com/lewagon/wait-on-check-action) from 1.3.1 to 1.3.3.
- [Release notes](https://github.com/lewagon/wait-on-check-action/releases)
- [Commits](lewagon/wait-on-check-action@v1.3.1...v1.3.3)

---
updated-dependencies:
- dependency-name: lewagon/wait-on-check-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Update ruff requirement from ==0.1.4 to ==0.1.9 (#2753)

Updates the requirements on [ruff](https://github.com/astral-sh/ruff) to permit the latest version.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@v0.1.4...v0.1.9)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel J. Beutel <daniel@flower.dev>

Add FedAvgM baseline (#2246)

Co-authored-by: Daniel J. Beutel <daniel@adap.com>
Co-authored-by: jafermarq <javier@flower.dev>

Add dockerfile for flower client image (#2746)

Add docker client image ci (#2747)

Rename `workload_id` to `run_id` (#2769)

Update README.md (#2771)

Format code examples (#2767)

Rename WorkloadState to RunState (#2770)

Add in-place FedAvg (#2293)

Update the error message when simulation crashes (#2759)

Add tests

Add tests

Fix tests

Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants