Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire the example of quickstart-xgboost-horizontal #2801

Merged
merged 10 commits into from Jan 18, 2024
Merged

Retire the example of quickstart-xgboost-horizontal #2801

merged 10 commits into from Jan 18, 2024

Conversation

yan-gao-GY
Copy link
Contributor

@yan-gao-GY yan-gao-GY commented Jan 16, 2024 •
edited

Issue

Description

We first thank the author for their contribution to this example. As the implementation of this example has been combined with a Flower baseline, we decide to remove this example.

Proposal

  1. Remove the example of quickstart-xgboost-horizontal.
  2. Move the related strategy FedXgbNnAvg to its baseline folder.

Changelog entry

@jafermarq jafermarq added the Examples Add or update a Flower example label Jan 18, 2024
@jafermarq jafermarq enabled auto-merge (squash) January 18, 2024 21:32
@jafermarq jafermarq merged commit 406f441 into main Jan 18, 2024
28 checks passed
@jafermarq jafermarq deleted the retire-xgboost-horizontal branch January 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
Examples Add or update a Flower example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yan-gao-GY @danieljanes @jafermarq