Update quickstart-pytorch example to use app model
#3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabdar-khan
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
…ower into tabdar/update-quickstart-pytorch
jafermarq
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Hey @tabdar-khan , I added some small changes to the code that were needed to keep things consistent w/ and w/o Flower Next. Let me know what you think
Comment on lines
104
to
114
| Or, to try the workflow example, run: | ||
|
|
||
| ```bash | ||
| flower-server-app server_workflow:app --insecure | ||
| ``` | ||
|
|
||
| Or, to try the custom server function example, run: | ||
|
|
||
| ```bash | ||
| flower-server-app server_custom:app --insecure | ||
| ``` |
There was a problem hiding this comment.
This was only relevant for the exampes/app-pytorch
Comment on lines
+50
to
+51
| ______________________________________________________________________ | ||
|
|
There was a problem hiding this comment.
I'm thinking we could remove these, since the immediately below section title will introduce one already.
| @@ -72,3 +74,29 @@ python3 client.py --partition-id 1 | |||
| ``` | |||
|
|
|||
| You will see that PyTorch is starting a federated training. Look at the [code](https://github.com/adap/flower/tree/main/examples/quickstart-pytorch) for a detailed explanation. | |||
|
|
|||
| ______________________________________________________________________ | |||
There was a problem hiding this comment.
remove? (also those in #3117?)
There was a problem hiding this comment.
Sure. I don't have a strong opinion about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
quickstart-pytorch example is outdated as it is not using the new app model from Flower Next.
Description
client.pyandserver.pyfiles in the quickstart-pytorch example to use the newappmodel.Changelog entry
Update quickstart-pytorch example to use
appmodel