Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Client Simulation #781

Merged
merged 33 commits into from Jul 26, 2021
Merged

Virtual Client Simulation #781

merged 33 commits into from Jul 26, 2021

Conversation

danieljanes
Copy link
Member

No description provided.

danieljanes and others added 25 commits May 19, 2021 11:37
@danieljanes
Create RayClientProxy
7547798
@tanertopal
Merge branch 'main' into virtualclient
a986136
@jafermarq
first working (still wip) implementation
eb15031
@jafermarq
Merge branch 'virtualclient' of https://github.com/adap/flower into v…
4fa63d8 
…irtualclient
@jafermarq
ray.init() moved to start_ray_simulation()
ccc884e
@danieljanes
Merge branch 'main' into virtualclient
93634ff
@danieljanes
Add optional ray dependency
56fee06
@jafermarq
added simulation_ray example
542162f
@danieljanes
Create simulation quickstart example
04d89ea
@danieljanes
Merge branch 'main' into virtualclient
159cbde
@jafermarq
Merge branch 'main' into virtualclient
2c2bdc4
@jafermarq
new directory for simulation code; minor updates to pytorch/tf examples
0c131a1
@jafermarq
fix for compatibility with latest Ray1.4.1
13302de
@jafermarq
Minor updates to pytorch example; added comments
99703e8
@danieljanes
Remove Ray examples
1d4e1d9
@danieljanes
Update module docstrings
0ce4303
@danieljanes
Auto-format code
2e8a57e
@danieljanes
Test if ray is importable
ff847b3
@danieljanes
Remove duplicate code
ccf9208
@danieljanes
Refactor RayClientProxy to be compatible with both Client and NumPyCl…
020ec8c 
…ient
@danieljanes
Merge branch 'main' into vcm0
f46c5e1
@danieljanes
Resolve lint issues
a3a4bbc
@danieljanes
Improve optional Ray import
acb6560
@danieljanes
Add proper docstrings
ba1b19f
@danieljanes
Refactor start_simulation arguments
f678953
@danieljanes danieljanes changed the title Virtual clients, part 0 Virtual Client Simulation Jul 24, 2021
@danieljanes danieljanes marked this pull request as ready for review July 25, 2021 19:03
tanertopal
tanertopal requested changes Jul 26, 2021
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments. One more thing:

src/py/flwr/simulation/ray_simulation/ seems a bit redundant so I would propose to rename it to:
src/py/flwr/simulation/ray/

src/py/flwr/simulation/app.py Outdated Show resolved Hide resolved
src/py/flwr/simulation/app.py Outdated Show resolved Hide resolved
@danieljanes
Copy link
Member Author

Left few comments. One more thing:

src/py/flwr/simulation/ray_simulation/ seems a bit redundant so I would propose to rename it to:
src/py/flwr/simulation/ray/

Renamed to ray_transport and pushed a commit with docstrings inspired by your suggestions

@tanertopal tanertopal merged commit 67cb2f3 into main Jul 26, 2021
@tanertopal tanertopal deleted the vcm0 branch July 26, 2021 08:50
@danieljanes danieljanes added this to In Progress in Virtual Client Engine via automation Aug 18, 2021
@danieljanes danieljanes moved this from In Progress to Done in Virtual Client Engine Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Virtual Client Engine
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieljanes @tanertopal @jafermarq