Fedopt baseline #919
Fedopt baseline #919
Conversation
adding `gpus_per_client`
@jafermarq changing gpus_per_client to 0.33
@jafermarq Again, changing now for cifar10
| torch = "^1.10.1" | ||
| torchvision = "^0.11.2" | ||
| omegaconf = { git = "https://github.com/pedropgusmao/omegaconf.git" } | ||
| hydra-core = { git = "https://github.com/pedropgusmao/hydra.git", branch="main" } |
There was a problem hiding this comment.
hydra-core and omegaconf deps make the process of poetry install hang in an endless resolving dependencies loop. If i comment these two lines out, poetry install runs (but ofcourse these two deps are not installed)
There was a problem hiding this comment.
Nevermind. It eventually ended... I found it faster to do first poetry install without those two deps. Then add them back and do poetry update....
There was a problem hiding this comment.
In my machine, it takes 1205.3s, which I think is way too long. I will have to dig deeper on this issue, but I think it could be a different PR.
There was a problem hiding this comment.
yeah, maybe i'm thinking the Readme can be updated to say ("oh, this can take a while...")
baselines/flwr_baselines/publications/adaptive_federated_optimization/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| You can run specific experiments by passing a `conf` subfolder and a given `strategy` as follows. | ||
| ```sh | ||
| python main.py --config-path conf/cifar10 strategy=fedyogi |
There was a problem hiding this comment.
After followiing the instructions in flower/baselines/README.md, I'm unable to run this:
➜ baselines poetry install # I ran this earlier and all got installed
Installing dependencies from lock file
No dependencies to install or update
Installing the current project: flwr_baselines (0.17.0)
➜ baselines cd flwr_baselines/publications/adaptive_federated_optimization
➜ adaptive_federated_optimization python main.py --config-path conf/cifar10 strategy=fedyogi
Traceback (most recent call last):
File "main.py", line 5, in <module>
import flwr as fl
ModuleNotFoundError: No module named 'flwr'
There was a problem hiding this comment.
It was probably the commented requirement you spotted earlier. I ran it again and it worked. Feel free to try again if you want
There was a problem hiding this comment.
I think the readme should be updated to indicate that after doing the poetry install one should do first poetry shell and then run the python command you have. I'd say let's assume nobody knows anything about virtualenvs or poetry. The error i had above is because i ran the python line exactly as instructed in the readme
There was a problem hiding this comment.
also, the strategy=fedyogi doesn't seem to work (it runs but hits NaN loss almost immediately) so maybe let's put good old FedAvg as the first example line?
There was a problem hiding this comment.
Are you using version 1.44 of grpcio ? This might be related to: ray-project/ray#22518
There was a problem hiding this comment.
it seems poetry install now does pull grpcio 1.43. I ran the example and seems to be fine (also w/ FedYogi)
There was a problem hiding this comment.
But i still stand to my previous message that it would be good to have some very minor instructions on how to setup the environment. If someone just comes to the readme of this example and tries to run the command in the readme, only error messages await. I'd say is enough to add a link to the top baselines readme (showing how to setup the env) and then update the readme here and add poetry run python3 main.py<...> instead of directly doing python main.py <..>
…get_properties becomes fully optional.
|
@jafermarq, would you mind running |
|
@pedropgusmao, I ran the example from scratch. Poetry pulls |
80% of it done