Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependencies in notebook examples #149

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

Lookatator
Copy link
Member

Solves issue #148

This PR introduces:

  • an installation of version 0.1.2 of brax instead of 0.0.15 in notebook examples using brax
  • an installation of Jumanji (version 0.2.2) in all notebooks installing QDax

Checks

  • a clear description of the PR has been added
  • (N/A) sufficient tests have been written
  • (N/A) relevant section added to the documentation
  • (N/A) example notebook added to the repo
  • (N/A) clean docstrings and comments have been written
  • if any issue/observation has been discovered, a new issue has been opened

Future improvements

Shall we only use Jumanji in its corresponding file? (and remove the Jumanji import from types.py) This way, we could use QDax brax environments (and others) without having to install Jumanji

@limbryan
Copy link
Collaborator

Agree for the future improvements for the Jumanji requirement. We can try to use the install with brackets like is done for gym (i.e. pip install gym[mujoco]). But let's do this in another PR!

@Lookatator Lookatator requested review from limbryan and removed request for felixchalumeau May 17, 2023 12:58
@codecov-commenter
Copy link

Codecov Report

Merging #149 (b07d1a7) into main (773e646) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         116      116           
  Lines        6763     6763           
=======================================
  Hits         6241     6241           
  Misses        522      522           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Lookatator Lookatator merged commit 1e016f1 into main May 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants