Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: target to use packageName rather than name on install (#196) #197

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: target to use packageName rather than name on install (#196) #197

merged 1 commit into from
Oct 3, 2023

Conversation

joe-allen-89
Copy link
Contributor

@joe-allen-89 joe-allen-89 commented Sep 19, 2023 •
edited
Loading

#196

Fix

@joe-allen-89 joe-allen-89 self-assigned this Sep 19, 2023
@joe-allen-89 joe-allen-89 linked an issue Sep 19, 2023 that may be closed by this pull request
adapt install / devinstall errors when using plugin's short name #196
Closed
@joe-allen-89 joe-allen-89 changed the title Fix: target to use packageName rather than package on install (#196) Fix: target to use packageName rather than name on install (#196) Sep 19, 2023
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

swashbuck
swashbuck approved these changes Oct 2, 2023
View reviewed changes
Copy link

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit fc69d6d into master Oct 3, 2023
2 checks passed
@oliverfoster oliverfoster deleted the issue/196 branch October 3, 2023 08:10
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@semantic-release-bot
Chore(release): 3.1.2 [skip ci]
c0777a7 
## [3.1.2](v3.1.1...v3.1.2) (2023-10-03)

### Fix

* target to use packageName rather than package on install (#197) ([fc69d6d](fc69d6d)), closes [#197](#197)
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt install / devinstall errors when using plugin's short name
4 participants
@joe-allen-89 @swashbuck @oliverfoster @cahirodoherty-learningpool