Fix: Prevent scrolling of container (fixes #254) #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unable to replicate this issue testing with the JSX PR adaptlearning/adapt-contrib-hotgraphic#256 Could you confirm if this is still an issue please @oliverfoster ? |
|
Can still replicate, chrome with nvda. Use arrow keys to navigate to any right button. |
eleanor-heath
approved these changes
Mar 24, 2023
|
Implicit +1 from conversations with @kirsty-hames |
|
🎉 This PR is included in version 7.4.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to robertmausser/adapt-contrib-narrative
that referenced
this pull request
Jul 10, 2023
# [5.1.0](v5.0.2...v5.1.0) (2023-07-10) ### chore * added package.json ([c80dc92](c80dc92)) * added package.json ([eef9b5d](eef9b5d)), closes [#3072](https://github.com/robertmausser/adapt-contrib-narrative/issues/3072) ### Fix * _globals schema nesting (adaptlearning#253) ([2cdb7ae](2cdb7ae)), closes [adaptlearning#253](https://github.com/robertmausser/adapt-contrib-narrative/issues/253) * Added gitignore for release automation (adaptlearning#237) ([bacab53](bacab53)), closes [adaptlearning#237](https://github.com/robertmausser/adapt-contrib-narrative/issues/237) * Added release automation (adaptlearning#234) ([dd45d5a](dd45d5a)), closes [adaptlearning#234](https://github.com/robertmausser/adapt-contrib-narrative/issues/234) * Bump http-cache-semantics from 4.1.0 to 4.1.1 (adaptlearning#246) ([b613166](b613166)), closes [adaptlearning#246](https://github.com/robertmausser/adapt-contrib-narrative/issues/246) * Convert to JSX, make progress indicators non-interactive (fixes adaptlearning#238 adaptlearning#244) ([7f7977a](7f7977a)), closes [adaptlearning#238](https://github.com/robertmausser/adapt-contrib-narrative/issues/238) [adaptlearning#244](https://github.com/robertmausser/adapt-contrib-narrative/issues/244) * Delay button update until after focus (fixes adaptlearning#261) (adaptlearning#266) ([949ee68](949ee68)), closes [adaptlearning#261](https://github.com/robertmausser/adapt-contrib-narrative/issues/261) [adaptlearning#266](https://github.com/robertmausser/adapt-contrib-narrative/issues/266) * Move breakpoint to medium from large (adaptlearning#264) ([65b1517](65b1517)), closes [adaptlearning#264](https://github.com/robertmausser/adapt-contrib-narrative/issues/264) * Move button labels to span tags (fixes adaptlearning#268) ([433b7f9](433b7f9)), closes [adaptlearning#268](https://github.com/robertmausser/adapt-contrib-narrative/issues/268) * Narrative focus being pulled on mobile fix (fixes adaptlearning#258) ([b60f8dc](b60f8dc)), closes [adaptlearning#258](https://github.com/robertmausser/adapt-contrib-narrative/issues/258) * Narrative item header level calculation (adaptlearning#257) ([c5abd1b](c5abd1b)), closes [adaptlearning#257](https://github.com/robertmausser/adapt-contrib-narrative/issues/257) * Prevent scrolling of container (fixes adaptlearning#254) (adaptlearning#255) ([cb6a6e9](cb6a6e9)), closes [adaptlearning#254](https://github.com/robertmausser/adapt-contrib-narrative/issues/254) [adaptlearning#255](https://github.com/robertmausser/adapt-contrib-narrative/issues/255) * Removed focus-rect (fixes adaptlearning#242) ([c3692de](c3692de)), closes [adaptlearning#242](https://github.com/robertmausser/adapt-contrib-narrative/issues/242) * Replace narrative view with hotgraphic view on parent (adaptlearning#265) ([8db789a](8db789a)), closes [adaptlearning#265](https://github.com/robertmausser/adapt-contrib-narrative/issues/265) * Resolve page scroll when user selects last item (adaptlearning#232) ([f4cf921](f4cf921)), closes [adaptlearning#232](https://github.com/robertmausser/adapt-contrib-narrative/issues/232) * Strapline overflow fix (adaptlearning#247) ([b011f23](b011f23)), closes [adaptlearning#247](https://github.com/robertmausser/adapt-contrib-narrative/issues/247) * Version numbers removed from Readme files ([47c8a59](47c8a59)) ### New * Issue and pr project addition automation (refs adaptlearning/adapt_framework#3315) (adaptlearning#233) ([b6836d6](b6836d6)), closes [adaptlearning#233](https://github.com/robertmausser/adapt-contrib-narrative/issues/233) * Normalize icons globally ([6c75165](6c75165)) * Provide default instruction text (fixes adaptlearning#240) (adaptlearning#241) ([7d3e560](7d3e560)), closes [adaptlearning#240](https://github.com/robertmausser/adapt-contrib-narrative/issues/240) [adaptlearning#241](https://github.com/robertmausser/adapt-contrib-narrative/issues/241) ### onItemsActiveChange * remove underscore from parameter and return early ([2eab40b](2eab40b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #254
Fix