Fix: Use parent children instead of stored siblings (#213)

adaptlearning · Mar 5, 2024 · 4aa09e6 · 4aa09e6
1 parent 7d6231f
commit 4aa09e6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/js/TrickleButtonModel.js b/js/TrickleButtonModel.js
@@ -56,7 +56,8 @@ export default class TrickleButtonModel extends ComponentModel {
     // Check if completion is blocked by another extension
     const isCompletionBlocked = (parentModel.get('_requireCompletionOf') === Number.POSITIVE_INFINITY);
     if (isCompletionBlocked) return;
-    return this.getSiblings().every(sibling => {
+    // use getParent().getChildren() instead of getSiblings() as children change but siblings don't
+    return this.getParent().getChildren().every(sibling => {
       if (sibling === this) {
         return true;
       }