Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: restoration issues across sessions or when switching languages #197

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Fix: restoration issues across sessions or when switching languages #197

merged 4 commits into from
Aug 30, 2023

Conversation

danielghost
Copy link
Contributor

@danielghost danielghost commented Jul 19, 2023 •
edited
Loading

Fixes #196.

Fix

  • Wait for models state to be restored before adding trickle, to resolve issues with models incorrectly unlocking/relocking across sessions, depending on page structure and trickle config.

Dependency

@danielghost danielghost self-assigned this Jul 19, 2023
@danielghost
Fix: wait for models state to be restored before adding trickle to re…
ca87b16 
…solve issues with models incorrectly unlocking/relocking across sessions (fixes #195, #196).
@danielghost danielghost mentioned this pull request Jul 20, 2023
Closed
@danielghost danielghost changed the title Fix: incorrect locked models when switching languages Fix: restoration issues across sessions or when switching languages Jul 20, 2023
@danielghost danielghost mentioned this pull request Jul 21, 2023
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danielghost danielghost merged commit 697f59c into master Aug 30, 2023
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
@semantic-release-bot
Chore(release): 7.0.1 [skip ci]
9e31452 
## [7.0.1](v7.0.0...v7.0.1) (2023-08-30)

### Fix

* restoration issues across sessions or when switching languages (#197) ([697f59c](697f59c)), closes [#197](#197) [#195](#195) [#196](#196)
@github-actions
Copy link

🎉 This PR is included in version 7.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect locked models when switching languages
4 participants
@danielghost @cahirodoherty-learningpool @eleanor-heath @joe-allen-89