Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add buttons after data ready (fixes #205) #206

Closed
wants to merge 2 commits into from
Closed

Fix: Add buttons after data ready (fixes #205) #206

wants to merge 2 commits into from

Conversation

oliverfoster
Copy link
Member

fixes adaptlearning/adapt-contrib-assessment#190

Fix

  • Wait for data ready before adding buttons. This is after spoor has restored and before assessment has captured its children. This allows assessment to correctly manage trickled blocks.

@oliverfoster oliverfoster self-assigned this Nov 21, 2023
@oliverfoster oliverfoster mentioned this pull request Nov 21, 2023
Merged
@oliverfoster oliverfoster deleted the issue/205 branch November 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trickle issue with reset assessment
1 participant
@oliverfoster