issue-1469: extended tutor

[oliverfoster]

fixes: adaptlearning/adapt_framework#1469

Added

• overlay and inline feedback options
• option of a notify text button at the bottom rather than a close button top right
• _classes to allow classes to be added to the feedback

Updated

• readme https://github.com/adaptlearning/adapt-contrib-tutor/tree/issue/1469#settings
• schema https://github.com/adaptlearning/adapt-contrib-tutor/blob/issue/1469/properties.schema

[oliverfoster]

i need help with schemas on this one. tutor + feedback are quite disjointed.
see bottom of the issue for my thoughts on supporting the schema.

[oliverfoster]

@tomgreenfield is taking this one for investigation

[oliverfoster]

@guywillis can you have a look at the styling
@oliverfoster can you do the accessibility testing

[tomgreenfield]

See questionView.js#L300 for the line in core where we could do with a { preventScroll: true }, to stop jerking on reset. done

[guywillis]

Some things to consider:

1. "_type": "none", - Turns off the feedback but leaves the show feedback button active. Should this be allowed?
2. "_type": "inline", + "_hasNotifyBottomButton": false, - Hide feedback button is still at the bottom of the inline feedback
3. "_type": "overlay", + "_hasNotifyBottomButton": true, - Hide feedback button is still the close icon in the top right of the overlay feedback

As an aside:

4. Is anyone aware of a method or config option to force buttons to be full width?

[cahirodoherty-learningpool]

👀

[oliverfoster]

Some things to consider:

1. "_type": "none", - Turns off the feedback but leaves the show feedback button active. Should this be allowed?
2. "_type": "inline", + "_hasNotifyBottomButton": false, - Hide feedback button is still at the bottom of the inline feedback
3. "_type": "overlay", + "_hasNotifyBottomButton": true, - Hide feedback button is still the close icon in the top right of the overlay feedback

As an aside:

4. Is anyone aware of a method or config option to force buttons to be full width?

1. Yes, as question has _canShowFeedback and a different extension may take the feedback for this item... probably? It's an edge case I'll admit.
2. Would you prefer "_hasBottomButton": true, ?
3. ^
4. In what context?

[oliverfoster]

@guywillis could you re-review please? / answer the above questions