Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed requests return 200 response #1736

Closed
dancgray opened this issue Oct 12, 2017 · 1 comment
Closed

Failed requests return 200 response #1736

dancgray opened this issue Oct 12, 2017 · 1 comment
Labels
I: major High priority bugs which don't immediately impact the user T: bug

Comments

@dancgray
Copy link
Member

e.g get /api/tenant/{id} where id cannot be found currently returns success: false in the response body JSON with 200 status. Status code should be 404.

Download endpoint is another example (api/output/{plugin}/publish/{id}).

This is inconsistent and not very useful, also probably not aligned with Restful API standards.

@canstudios-louisem canstudios-louisem added this to the 0.5.0 milestone Oct 30, 2017
@taylortom taylortom modified the milestones: Suggested Next, 0.?.0 Backend refactor Feb 5, 2018
@taylortom taylortom added T: bug I: major High priority bugs which don't immediately impact the user labels Mar 26, 2019
@taylortom
Copy link
Member

This will be sorted after the rewrite 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: major High priority bugs which don't immediately impact the user T: bug
Projects
None yet
Development

No branches or pull requests

3 participants