Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events need consistent naming conventions #1746

Closed
taylortom opened this issue Oct 18, 2017 · 2 comments
Closed

Events need consistent naming conventions #1746

taylortom opened this issue Oct 18, 2017 · 2 comments
Labels
D: easy Straightforward issues, small time commitment I: minor Low, impact, low priority bugs T: enhancement Adding additional functionality

Comments

@taylortom
Copy link
Member

General housekeeping task.

The way events have been named is often overly verbose, not always self-evident, and often inconsistent. Some examples:

  • location:title:update could just be location:setTitle
  • remove:views - we generally use the structure MODULE:ACTION , so origin:removeViews or just origin:remove seems more logical

The first step is probably to document all events in the system, and decide a sensible structure from there.

@taylortom taylortom added D: easy Straightforward issues, small time commitment I: minor Low, impact, low priority bugs T: enhancement Adding additional functionality labels Oct 18, 2017
@taylortom
Copy link
Member Author

Need to settle on consistent conventions for both front and back end

@taylortom
Copy link
Member Author

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: easy Straightforward issues, small time commitment I: minor Low, impact, low priority bugs T: enhancement Adding additional functionality
Projects
None yet
Development

No branches or pull requests

1 participant