Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full path to pikaday #2314

Closed
lc-thomasberger opened this issue Apr 25, 2019 · 0 comments
Closed

full path to pikaday #2314

lc-thomasberger opened this issue Apr 25, 2019 · 0 comments
Assignees
Labels
S: merged Completed, reviewed, and merged issues T: bug

Comments

@lc-thomasberger
Copy link
Member

In the filterView of user management the path to pikaday is absolute. This breaks grunt build (requireJS) if a plugin uses the shim name of the library directly.

https://github.com/adaptlearning/adapt_authoring/blob/master/frontend/src/modules/userManagement/views/filterView.js#L3

I think we should update this and use the library name instead of the full path as this is used for most libraries.

Versions

  • Authoring Tool Version: 0.7.x
  • Framework Version: --
  • Node.js Version: --
  • MongoDB Version: --
  • Operating System: --
  • Browser: --
@lc-thomasberger lc-thomasberger added this to the Bug patch #2 milestone Apr 25, 2019
@lc-thomasberger lc-thomasberger self-assigned this Apr 25, 2019
@canstudios-nicolaw canstudios-nicolaw modified the milestones: 0.8.1, Bugpatch May 28, 2019
@lc-thomasberger lc-thomasberger added S: awaiting-review Completed issues waiting on reviews S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Development

No branches or pull requests

3 participants