Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image thumbnails not showing in scaffold #2345

Closed
dancgray opened this issue May 22, 2019 · 1 comment
Closed

Image thumbnails not showing in scaffold #2345

dancgray opened this issue May 22, 2019 · 1 comment
Labels
S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.9.0 Less is more

Comments

@dancgray
Copy link
Member

Expected Behaviour

Image thumbnail should show in component settings editor

Actual Behaviour

Place holder image icon is always shown.

Steps to Reproduce

  1. Upload an image and check that the thumbnail has been made and is viewable in asset manager
  2. Add a graphic component to a course using previous image
  3. Placeholder icon will be shown e.g.

Screenshot 2019-05-22 at 15 24 39

This commit means that fetchCourseAsset uses course ID instead of block ID for _contentTypeParentId search criteria here.

Versions

  • Authoring Tool Version: v0.8.0
  • Framework Version: v2.4.0
  • Node.js Version: 10.15.3
  • MongoDB Version: 3.6
  • Operating System: macOS 10.14.5
  • Browser: Chrome
@dancgray
Copy link
Member Author

Possible solution: change searchCriteria._contentTypeParentId to searchCriteria._courseId ?

@dancgray dancgray mentioned this issue May 24, 2019
Merged
@dancgray dancgray added the S: awaiting-review Completed issues waiting on reviews label May 24, 2019
@canstudios-nicolaw canstudios-nicolaw added this to the Bugpatch milestone May 28, 2019
@samumist samumist mentioned this issue May 30, 2019
Closed
@canstudios-nicolaw canstudios-nicolaw added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.9.0 Less is more
Development

No branches or pull requests
2 participants
@dancgray @canstudios-nicolaw