Pooling workflows and Shared connections fun. #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread safe maps.
… Collections.synchronizedMap. Also added a unit test that consistently fails when not wrapping the weak map.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1116 +/- ##
=============================================
- Coverage 93.47% 93.45% -0.02%
- Complexity 11129 11130 +1
=============================================
Files 1086 1086
Lines 29867 29870 +3
Branches 2105 2105
=============================================
- Hits 27918 27916 -2
- Misses 1519 1523 +4
- Partials 430 431 +1
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sebastien-belin-adp
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If you have a pooling workflow that has references to a shared connection, then upon init/start you can get into a situation where multiple threads (each being a worker for the pooling workflow) attempt to register themselves as listeners to the shared connection.
This list of listeners in the shared connection was not thread safe and could cause an infinite loop resulting in Interlok app[earling to hang.
Modification
Simple changed the maps holding the consumers/producers and listeners to be thread safe versions.
Result
Interlok no longer hangs on startup when using a pooling workflow that references shared connections.