Extend model objects with CustomStringConvertible #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larryonoff thanks, we'll get back to it asap. ETA – beginning of the next week. |
|
@larryonoff it might be worth to remove app libs updates and keep only StringConvertible extension? |
|
@Skifcha sure. will do. |
This reverts commit fbfd4be.
|
@Skifcha done |
AKyashkin
reviewed
Oct 14, 2020
|
@larryonoff can you add this file to SDK? The rest looks fine. |
Sorry. I'm not sure I understand what you mean. Adapty.podspec has pattern for source files in Classes folder, so that Package.swift. I don't see where should I add new file. |
|
The Project itself doesn't see this file in case of the dev pod. No worries, I'll add this small thing later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.