-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pre-commit with black, flake8, isort checks #142
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 8 8
Lines 880 880
=======================================
Hits 872 872
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Thanks, I'll test the PR first and then accept it if everything works. |
There is something wrong with the flake8 dependency, it asks for a password. We could also add mypy since we're at it and also the hooks suggested here:
|
It works, thanks! |
fiix #120