Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit with black, flake8, isort checks #142

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

nadasuhailAyesh12
Copy link
Contributor

@nadasuhailAyesh12 nadasuhailAyesh12 commented Mar 21, 2024

fiix #120

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (3e8ba44) to head (8561fd9).

❗ Current head 8561fd9 differs from pull request most recent head 373412f. Consider uploading reports for the commit 373412f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files           8        8           
  Lines         880      880           
=======================================
  Hits          872      872           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adbar
Copy link
Owner

adbar commented Mar 21, 2024

Thanks, I'll test the PR first and then accept it if everything works.

@adbar
Copy link
Owner

adbar commented Mar 22, 2024

There is something wrong with the flake8 dependency, it asks for a password.

We could also add mypy since we're at it and also the hooks suggested here:

# - repo: .. (mypy)
# ...
-   repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v2.3.0
    hooks:
    -   id: check-yaml
    -   id: end-of-file-fixer
    -   id: trailing-whitespace

@adbar adbar changed the title add pre-commit with block,flake8,isort checks add pre-commit with black, flake8, isort checks Mar 22, 2024
@adbar
Copy link
Owner

adbar commented Mar 25, 2024

It works, thanks!

@adbar adbar merged commit b5b95da into adbar:master Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants