Sourcery refactored main branch #6
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| def hyphenated_filter(vocab: Dict[str, Entry], perc: float=50, verbose: bool=False) -> Dict[str, Entry]: # threshold in percent | ||
| def hyphenated_filter(vocab: Dict[str, Entry], perc: float=50, verbose: bool=False) -> Dict[str, Entry]: # threshold in percent |
There was a problem hiding this comment.
Function hyphenated_filter refactored with the following changes:
- Simplify comparison to boolean (
simplify-boolean-comparison)
| if oldnessindex < datethreshold: | ||
| #if oldnessindex < np.percentile(series, percentage): | ||
| # continue | ||
| if freshnessindex < np.percentile(series, percentage): | ||
| deletions.append(token) | ||
| # print(vocab[token], freshnessindex, oldnessindex, token) | ||
| if oldnessindex < datethreshold and freshnessindex < np.percentile( | ||
| series, percentage | ||
| ): | ||
| deletions.append(token) |
There was a problem hiding this comment.
Function freshness_filter refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
This removes the following comments ( why? ):
# continue
#if oldnessindex < np.percentile(series, percentage):
# print(vocab[token], freshnessindex, oldnessindex, token)
| if keep_words is False: | ||
| deletions = list(intersection) | ||
| else: | ||
| deletions = [w for w in vocab if w not in intersection] | ||
| deletions = ( | ||
| [w for w in vocab if w not in intersection] | ||
| if keep_words | ||
| else list(intersection) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function wordlist_filter refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression) - Replace if statement with if expression (
assign-if-exp) - Simplify comparison to boolean (
simplify-boolean-comparison)
| match = DATESEARCH.search(thepath) | ||
| if match: | ||
| if match := DATESEARCH.search(thepath): |
There was a problem hiding this comment.
Function find_files refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| if details is True: | ||
| if details: |
There was a problem hiding this comment.
Function read_file refactored with the following changes:
- Simplify comparison to boolean (
simplify-boolean-comparison)
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!