Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#320 - update deprecated code #321

Merged
merged 2 commits into from Apr 11, 2023
Merged

#320 - update deprecated code #321

merged 2 commits into from Apr 11, 2023

Conversation

sdondley
Copy link
Contributor

@sdondley sdondley commented Apr 9, 2023

No description provided.

@adbar
Copy link
Owner

adbar commented Apr 11, 2023

Hi @sdondley, thanks for pointing that out. The lambda solution you suggest isn't by any way solving any deprecation issue though, or am I missing something?
In any case, I would rather be in favor of filter(None, ...).

@adbar adbar linked an issue Apr 11, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #321 (82551a4) into master (2639b24) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          21       21           
  Lines        3268     3268           
=======================================
  Hits         3149     3149           
  Misses        119      119           
Impacted Files Coverage Δ
trafilatura/core.py 98.10% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adbar
Copy link
Owner

adbar commented Apr 11, 2023

I got your point and added similar changes. The lambda function may be slightly slower but keeping the code base up to date is more important. Thanks!

@adbar adbar merged commit 55237a7 into adbar:master Apr 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting warnings while testing extract() function with with pytest
3 participants