Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Extraction when Meta tag has an empty content #545

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Fixed Extraction when Meta tag has an empty content #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3eaa74c
Check for empty content on meta tags - metadata.py
felipehertzer Apr 5, 2024
b2deb43
Added tests for empty meta tags metadata_tests.py
felipehertzer Apr 5, 2024
97ee9ff
Merge pull request #2 from felipehertzer/patch-4
felipehertzer Apr 5, 2024
d04d78a
fixed test
felipehertzer Apr 5, 2024
b4f037a
fixed test
felipehertzer Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/metadata_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ def test_titles():
# too short/empty
metadata = extract_metadata('<html><body><h3 class="title">T</h3><h3 id="title"></h3></body></html>')
assert metadata.title is None

metadata = extract_metadata('<html><head><title>Test Title</title><meta property="og:title" content=" " /></head><body><h1>First</h1></body></html>')
assert metadata.title == 'First'
metadata = extract_metadata('<html><head><title>Test Title</title><meta name="title" content=" " /></head><body><h1>First</h1></body></html>')
assert metadata.title == 'First'
metadata = extract_metadata('<html><head><title>Test Title</title></head><body></body></html>')
assert metadata.title == 'Test Title'
metadata = extract_metadata('<html><body><h1>First</h1><h1>Second</h1></body></html>')
Expand Down
4 changes: 2 additions & 2 deletions trafilatura/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def extract_opengraph(tree):
# detect OpenGraph schema
for elem in tree.xpath('.//head/meta[starts-with(@property, "og:")]'):
# safeguard
if not elem.get('content'):
if not elem.get('content') or elem.get('content').isspace():
continue
# site name
if elem.get('property') == 'og:site_name':
Expand Down Expand Up @@ -212,7 +212,7 @@ def examine_meta(tree):
# skim through meta tags
for elem in tree.iterfind('.//head/meta[@content]'):
# content
if not elem.get('content'):
if not elem.get('content') or elem.get('content').isspace():
continue
content_attr = HTML_STRIP_TAG.sub('', elem.get('content'))
# image info
Expand Down
Loading