fix: broken selectable question with undefined defaultValue

adbayb · Mar 23, 2022 · 95aad1a · 95aad1a
1 parent 457804a
commit 95aad1a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/continuous_integration.yml → .github/workflows/integrate.yml b/.github/workflows/continuous_integration.yml → .github/workflows/integrate.yml
diff --git a/example/withQuestion.ts b/example/withQuestion.ts
@@ -17,6 +17,7 @@ program
 		key: "question1",
 		label: "What is your single choice?",
 		options: ["singleOption1", "singleOption2"],
+		defaultValue: "singleOption2",
 	})
 	.question({
 		type: "multiselect",

diff --git a/src/features/question/index.ts b/src/features/question/index.ts
@@ -53,9 +53,11 @@ export const createQuestion: CreateInstruction<
 			// we need to do some transformation to plug termost API with prompts one...
 			if (isMultiSelect) promptObject.initial = undefined;
 			else {
-				promptObject.initial = options.findIndex(
+				const foundIndex = options.findIndex(
 					(option) => option === defaultValue
 				);
+
+				promptObject.initial = foundIndex >= 0 ? foundIndex : undefined;
 			}
 
 			promptObject.choices = choices;

diff --git a/test/__snapshots__/index.test.ts.snap b/test/__snapshots__/index.test.ts.snap
@@ -60,10 +60,10 @@ exports[`termost should handle \`command\` api 4`] = `
 [94m   👋 Hello, I'm the build command[39m
 [94m[1m[22m[39m
 [94m[1mℹ️  Information[22m[39m
-[94m   👉 Shared global flag = false[39m
+[94m   👉 Shared global flag = true[39m
 [94m[1m[22m[39m
 [94m[1mℹ️  Information[22m[39m
-[94m   👉 Local command flag = local-value[39m"
+[94m   👉 Local command flag = hello[39m"
 `;
 
 exports[`termost should handle \`command\` api 5`] = `
@@ -72,7 +72,7 @@ exports[`termost should handle \`command\` api 5`] = `
 [94m   👋 Hello, I'm the watch command[39m
 [94m[1m[22m[39m
 [94m[1mℹ️  Information[22m[39m
-[94m   👉 Shared global flag = false[39m"
+[94m   👉 Shared global flag = true[39m"
 `;
 
 exports[`termost should handle \`command\` api 6`] = `

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -22,10 +22,10 @@ describe("termost", () => {
 			"node -r esbuild-register example/withCommand.ts watch"
 		);
 		const buildSharedFlagOutput = await exec(
-			"node -r esbuild-register example/withCommand.ts build --flag"
+			"node -r esbuild-register example/withCommand.ts build --global --local hello"
 		);
 		const watchSharedFlagOutput = await exec(
-			"node -r esbuild-register example/withCommand.ts watch --flag"
+			"node -r esbuild-register example/withCommand.ts watch --global"
 		);
 		const buildHelpOutput = await exec(
 			"node -r esbuild-register example/withCommand.ts build --help"