Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run example scripts on CI #142

Open
maxscheurer opened this issue Jan 13, 2022 · 4 comments
Open

Run example scripts on CI #142

maxscheurer opened this issue Jan 13, 2022 · 4 comments
Labels
CI Related to CI and CD testing Test system and test improvements

Comments

@maxscheurer
Copy link
Member

It would be good to run the small/fast example scripts on CI to ensure that these remain intact.

@maxscheurer maxscheurer added testing Test system and test improvements CI Related to CI and CD labels Jan 13, 2022
@maxscheurer
Copy link
Member Author

What's the best way to run the examples btw? We somehow need to select the files according to available host programs, etc., and I don't have a clean way to do this in mind yet 😄

@mfherbst
Copy link
Member

That's a good point. I guess pyscf and psi4 are easy to install and then we just run all scripts that contain an 'import pyscf' or 'import psi4' and which don't contain a flag indicating that they are too expensive. That should cover 90%.

@maxscheurer
Copy link
Member Author

Psi4 is not easy to install outside the conda env, and even there, it can become difficult, as @loriab and I discovered last week due to mixture of c-f and defaults channel 😄

I saw that you've tagged your DFTK examples with some comment, I think that's a nice solution!

@mfherbst
Copy link
Member

I saw that you've tagged your DFTK examples with some comment, I think that's a nice solution!

Yes it works ok, but have reached a limit there in the sense that the number of examples becomes large enough that we need to think about a clever way to save ci time there ... but we choose an opt-out solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Related to CI and CD testing Test system and test improvements
Projects
None yet
Development

No branches or pull requests

2 participants