Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate InvalidReference.py #136

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Remove duplicate InvalidReference.py #136

merged 1 commit into from
Jan 6, 2022

Conversation

maxscheurer
Copy link
Member

Removes unused file, duplicate in adcc/exceptions.py.

@maxscheurer
Delete InvalidReference.py
87ad0e2 
Removes unused file, duplicate in `adcc/exceptions.py`
mfherbst
mfherbst approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@mfherbst mfherbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked there is no impact on downstream stuff (QCEngine, Psi4) ?

@mfherbst
Copy link
Member

mfherbst commented Jan 6, 2022

Just saw the PR on psi4 👍.

@maxscheurer
Copy link
Member Author

qcengine does not seem to be affected 😉

@maxscheurer maxscheurer merged commit 91fa19f into master Jan 6, 2022
@maxscheurer maxscheurer deleted the maxscheurer-patch-1 branch January 6, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfherbst mfherbst mfherbst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxscheurer @mfherbst