New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement isrmatrix_vector_product #154
implement isrmatrix_vector_product #154
Conversation
Thanks for the contribution. I think the implementation should be in line with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Just a few comments, tests look good to me. After addressing the comments, we can merge this 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 👍
You want to give this another look, @mfherbst?
@apapapostolou It would be great if you could try to update the TPA example using your new |
Thanks a lot for updating the example @apapapostolou 🚀 |
Is this ready from your side, @apapapostolou? 😄 |
Yes, it is 😄 |
@apapapostolou feel free to create a PR and add yourself to the contributors/authors! 😬 |
Implement and test the matrix-vector product of an ISR one-particle operator through second order in perturbation theory. Both symmetric and asymmetric one-particle operators are allowed.