Implement crude estimates for memory requirements #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mfherbst
force-pushed
the
memory-estimates
branch
from
69621a4
to
7cfe289
Compare
maxscheurer
reviewed
Apr 5, 2020
| count["ovov"] += 1 # M11 intermediate | ||
| count["ovvv"] += 3 # t2eri + Pia intermediate | ||
| count["ooov"] += 3 # t2eri + Pib intermediate | ||
| eriimport = "vvvv" |
There was a problem hiding this comment.
Probably we should also count the oooo and vvvv block if properties are requested?
There was a problem hiding this comment.
Good point, but this PR is far away from such micro-optimisation at the moment, unfortunately ... the results are still incredibly unreliable.
|
Closing this now ... #71 will changes so much of the workflow, that this work is most likely outdated anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_adc.Fixes #27.